Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update test fixture to use geth v1.11.2 #2841

Merged
merged 3 commits into from
Feb 23, 2023

Conversation

fselmo
Copy link
Collaborator

@fselmo fselmo commented Feb 23, 2023

What was wrong?

  • Update py-geth version to >=3.11.0 to pull in support for geth v1.11.2
  • Generate new integration test fixture with geth v1.11.2
  • Additional commands needed for starting geth. Need to specify etherbase explicitly now and personal namespace is deprecated so needs a special flag to turn it on.

Todo:

Cute Animal Picture

20230223_150224

@fselmo fselmo force-pushed the upgrade-test-fixture-to-geth-1.11.2 branch 4 times, most recently from 4db0a55 to b58eb3e Compare February 23, 2023 20:49
@fselmo fselmo force-pushed the upgrade-test-fixture-to-geth-1.11.2 branch 2 times, most recently from bed13a0 to 3bf3550 Compare February 23, 2023 22:01
@fselmo fselmo marked this pull request as ready for review February 23, 2023 22:04
@fselmo fselmo force-pushed the upgrade-test-fixture-to-geth-1.11.2 branch from 3bf3550 to 99c0e1a Compare February 23, 2023 22:05
Copy link
Collaborator

@kclowes kclowes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

@fselmo fselmo merged commit 90a9ad3 into ethereum:master Feb 23, 2023
@fselmo fselmo deleted the upgrade-test-fixture-to-geth-1.11.2 branch April 25, 2023 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants